1.3.0 Geburtstagslogik verbessert

This commit is contained in:
Borgal
2025-11-16 21:26:21 +01:00
parent ddcd614a49
commit 0cb4ca932c
3 changed files with 80 additions and 55 deletions

View File

@@ -180,10 +180,10 @@ if ($row) {
} }
// --- ZAHLENDE PERSON BESTIMMEN --- // --- ZAHLENDE PERSON BESTIMMEN ---
$next_payer_username = null; $next_payer_info = null;
if ($total_accepted > 0) { if ($total_accepted > 0) {
include_once('zahler.php'); include_once('zahler.php');
$next_payer_username = get_next_payer_username($conn, $meeting_id); $next_payer_info = get_next_payer_info($conn, $meeting_id);
} }
@@ -369,10 +369,15 @@ $german_weekdays = [
<!-- Horizontale Linie hier einfügen --> <!-- Horizontale Linie hier einfügen -->
<hr class="my-1"> <hr class="my-1">
<?php if ($next_payer_username): ?> <?php if ($next_payer_info): ?>
<div class="text-center my-2 mx-auto" style="max-width: 500px; border-radius: 0.5rem;"> <div class="text-center my-2 mx-auto" style="max-width: 500px; border-radius: 0.5rem;">
<p class="fw-bold mb-1">Rechnung wird bezahlt von:</p> <p class="fw-bold mb-1">Rechnung wird bezahlt von:</p>
<h4 class="text-muted fw-bold mb-0"><?= htmlspecialchars($next_payer_username); ?></h4> <h4 class="text-muted fw-bold mb-0">
<?= htmlspecialchars($next_payer_info['username']); ?>
<?php if ($next_payer_info['is_birthday_payer']): ?>
<span class="material-symbols-outlined align-text-bottom" style="font-size: 1.1em; color: #ff6f00;" title="Geburtstagsvorschlag">cake</span>
<?php endif; ?>
</h4>
</div> </div>
<?php endif; ?> <?php endif; ?>

View File

@@ -85,17 +85,15 @@ if ($_SERVER["REQUEST_METHOD"] === "POST") {
} }
mysqli_stmt_close($stmt_insert); mysqli_stmt_close($stmt_insert);
// 🔹 GEBURTSTAGS-REGEL: last_birthday_year NUR setzen, wenn Geburtstag bereits war // 🔹 GEBURTSTAGS-ZAHLUNG BEHANDELN
$current_year = (int)date('Y');
$meeting_date_for_bday = $meeting['meeting_date'];
foreach ($_POST['user_id'] as $user_id) { foreach ($_POST['user_id'] as $user_id) {
$user_id = (int)$user_id; $user_id = (int)$user_id;
$paid = isset($_POST['paid'][$user_id]) && $_POST['paid'][$user_id] == 1; $paid = isset($_POST['paid'][$user_id]) && $_POST['paid'][$user_id] == 1;
if (!$paid) continue; if (!$paid) continue;
$user_stmt = mysqli_prepare($conn, "SELECT birthday FROM users WHERE id = ? AND birthday IS NOT NULL"); // Hole aktuellen Status
$user_stmt = mysqli_prepare($conn, "SELECT birthday_payer_pending FROM users WHERE id = ?");
mysqli_stmt_bind_param($user_stmt, "i", $user_id); mysqli_stmt_bind_param($user_stmt, "i", $user_id);
mysqli_stmt_execute($user_stmt); mysqli_stmt_execute($user_stmt);
$user_row = mysqli_fetch_assoc(mysqli_stmt_get_result($user_stmt)); $user_row = mysqli_fetch_assoc(mysqli_stmt_get_result($user_stmt));
@@ -103,20 +101,28 @@ if ($_SERVER["REQUEST_METHOD"] === "POST") {
if (!$user_row) continue; if (!$user_row) continue;
$birthday = $user_row['birthday']; $was_birthday_payer = (bool)$user_row['birthday_payer_pending'];
$birth_month = (int)date('m', strtotime($birthday));
$birth_day = (int)date('d', strtotime($birthday));
$birthday_this_year = "$current_year-$birth_month-$birth_day";
if (strtotime($birthday_this_year) <= strtotime($meeting_date_for_bday)) { if ($was_birthday_payer) {
$update_stmt = mysqli_prepare($conn, " // 🎂 Geburtstags-Zahlung: NICHT zählen, aber Flag zurücksetzen
$update = mysqli_prepare($conn, "
UPDATE users UPDATE users
SET last_birthday_year = ? SET birthday_payer_pending = 0
WHERE id = ? WHERE id = ?
"); ");
mysqli_stmt_bind_param($update_stmt, "ii", $current_year, $user_id); mysqli_stmt_bind_param($update, "i", $user_id);
mysqli_stmt_execute($update_stmt); mysqli_stmt_execute($update);
mysqli_stmt_close($update_stmt); mysqli_stmt_close($update);
} else {
// 🔢 Normale Zahlung: reguläre Anzahl erhöhen
$update = mysqli_prepare($conn, "
UPDATE users
SET regular_paid_count = regular_paid_count + 1
WHERE id = ?
");
mysqli_stmt_bind_param($update, "i", $user_id);
mysqli_stmt_execute($update);
mysqli_stmt_close($update);
} }
} }

View File

@@ -1,59 +1,73 @@
<?php <?php
function get_next_payer_username($conn, $meeting_id)
{
$current_year = (int)date('Y');
// Alle zugesagten Nutzer mit paid_count /**
* Gibt den Vorschlag für den nächsten Rechnungszahler zurück.
* Liefert ein Array: ['username' => ..., 'is_birthday_payer' => true/false]
*/
function get_next_payer_info($conn, $meeting_id)
{
// Meeting-Datum holen
$stmt = mysqli_prepare($conn, "SELECT meeting_date FROM meetings WHERE id = ?");
mysqli_stmt_bind_param($stmt, "i", $meeting_id);
mysqli_stmt_execute($stmt);
$meeting = mysqli_fetch_assoc(mysqli_stmt_get_result($stmt));
mysqli_stmt_close($stmt);
if (!$meeting) {
return null;
}
$meeting_date = $meeting['meeting_date'];
$current_year = (int)date('Y', strtotime($meeting_date));
// Alle ZUSAGENDEN Teilnehmer dieses Meetings
$sql = " $sql = "
SELECT SELECT
u.id, u.id,
u.username, u.username,
u.birthday, u.birthday,
u.last_birthday_year, u.birthday_payer_pending,
(SELECT COUNT(*) FROM meeting_teilnehmer WHERE user_id = u.id AND paid = 1) AS paid_count u.regular_paid_count
FROM meeting_teilnehmer mt FROM meeting_teilnehmer mt
JOIN users u ON mt.user_id = u.id JOIN users u ON mt.user_id = u.id
WHERE mt.meeting_id = ? AND mt.rsvp_status = 'accepted' WHERE mt.meeting_id = ? AND mt.rsvp_status = 'accepted'
ORDER BY u.username ORDER BY u.username
"; ";
$stmt = mysqli_prepare($conn, $sql); $stmt = mysqli_prepare($conn, $sql);
mysqli_stmt_bind_param($stmt, "i", $meeting_id); mysqli_stmt_bind_param($stmt, "i", $meeting_id);
mysqli_stmt_execute($stmt); mysqli_stmt_execute($stmt);
$candidates = mysqli_fetch_all(mysqli_stmt_get_result($stmt), MYSQLI_ASSOC); $candidates = mysqli_fetch_all(mysqli_stmt_get_result($stmt), MYSQLI_ASSOC);
mysqli_stmt_close($stmt); mysqli_stmt_close($stmt);
if (empty($candidates)) return null; if (empty($candidates)) {
return null;
// Finde minimale paid_count
$min_paid = min(array_column($candidates, 'paid_count'));
$eligible = array_filter($candidates, fn($c) => $c['paid_count'] == $min_paid);
$birthday_eligible = [];
$others = [];
foreach ($eligible as $c) {
$is_birthday_payer_eligible = (
!empty($c['birthday'])
&& $c['birthday'] !== '0000-00-00'
&& $c['last_birthday_year'] != $current_year
);
if ($is_birthday_payer_eligible) {
$birthday_eligible[] = $c;
} else {
$others[] = $c;
}
} }
// Sortiere alphabetisch // 🔹 PRIORITÄT 1: Geburtstags-Zahler (birthday_payer_pending = 1)
$sort = fn($a, $b) => strcmp($a['username'], $b['username']); $birthday_candidates = array_filter($candidates, fn($c) => $c['birthday_payer_pending'] == 1);
if (!empty($birthday_candidates)) {
if (!empty($birthday_eligible)) { usort($birthday_candidates, fn($a, $b) => strcmp($a['username'], $b['username']));
usort($birthday_eligible, $sort); $first = $birthday_candidates[0];
return $birthday_eligible[0]['username']; return [
'username' => $first['username'],
'is_birthday_payer' => true
];
} }
$all = array_merge($birthday_eligible, $others); // 🔹 PRIORITÄT 2: Normale Rotation (nach regular_paid_count)
usort($all, $sort); $min_paid = min(array_column($candidates, 'regular_paid_count'));
return $all[0]['username']; $regular_candidates = array_filter($candidates, fn($c) => $c['regular_paid_count'] == $min_paid);
usort($regular_candidates, fn($a, $b) => strcmp($a['username'], $b['username']));
$first = $regular_candidates[0];
return [
'username' => $first['username'],
'is_birthday_payer' => false
];
}
function get_next_payer_username($conn, $meeting_id)
{
$info = get_next_payer_info($conn, $meeting_id);
return $info ? $info['username'] : null;
} }